Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel.
6 comments:
Commit Message:
Patch Set #2, Line 10: making
Imperative mood: make
Done
Patch Set #2, Line 11: moving
move
Removed.
Also, moving the storage devices to brox
overridetree.cb as they are specific to this board.
A separate commit would be nice.
Moved to https://review.coreboot.org/c/coreboot/+/79995
File src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb:
Patch Set #2, Line 180: device ref pcie4_0 on
Probably separate the PCIE with another CL?
Moved to https://review.coreboot.org/c/coreboot/+/79995
File src/mainboard/google/brox/variants/brox/overridetree.cb:
Patch Set #1, Line 8: option STORAGE_UFS 0
If you think emmc might be added later, might be better to make this […]
Done
1) It will likely need a field for WiFi Device (not sure if kernel will need a field for WLAN type a […]
Nick, can you review these fw config settings to make sure that they cover your conerns?
To view, visit change 79854. To unsubscribe, or for help writing mail filters, visit settings.