Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G
......................................................................
Patch Set 54:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35523/45//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/45//COMMIT_MSG@28
PS45, Line 28: - Remaining RAM slots (need other SPD addresses)
The vendor firmware and dmidecode list 4, but the internet says that there are only 2. […]
Um, RAM slots are a physical thing you can count. For example, a random board off the internets:
https://us.v-cdn.net/6029997/uploads/editor/2l/a82ghszhap9b.jpg
There's two slots, each can take a SO-DIMM. On laptops, there's usually only two SO-DIMM slots.
If there's onboard memory (memory-down), there's usually the equivalent of one or two DIMMs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 54
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 12 Jan 2020 20:37:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment