Attention is currently required from: Bao Zheng, Martin Roth, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48528 )
Change subject: soc/amd/cezanne: Add PSP integration for cezanne ......................................................................
Patch Set 29:
(6 comments)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/48528/comment/ccdce65b_fd5b3fc6 PS29, Line 163: config PSP_LOAD_MP2_FW not sure if PSP_LOAD_MP2_FW and PSP_LOAD_S0I3_FW should be default y. for PSP_UNLOCK_SECURE_DEBUG i agree that it should be default y for now and changed back when we're done with the platform bring-up. i'm ok with keeping it as it is right now and have another look at it later
File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48528/comment/81a767f1_d075495d PS29, Line 46: CONFIG_AMD_FWM_POSITION_INDEX there should probably be a check to make sure that this isn't an empty string instead of the number and if it is empty throw an error. see https://docs.zephyrproject.org/1.14.0/guides/kconfig/index.html#redundant-de... on the default of int in Kconfig. same for picasso
https://review.coreboot.org/c/coreboot/+/48528/comment/a00647c7_2af1a61a PS29, Line 113: OPT_APOB_ADDR=$(call add_opt_prefix, $(PSP_APOB_BASE), --apob-base) the other apob related things aren't in here, so i wonder if this one should also be removed for now and added back when the apob support is added
https://review.coreboot.org/c/coreboot/+/48528/comment/cfe8a8aa_29518e5a PS29, Line 137: $(OPT_SEC_DEBUG_FILE) \ this variable doesn't exist, so should probably be removed. same for picasso
https://review.coreboot.org/c/coreboot/+/48528/comment/052e7d5c_73fa99d3 PS29, Line 154: $(OPT_PSPBTLDR_FILE) \ this variable seems to be undefined, so i guess it can be removed. same for picasso
https://review.coreboot.org/c/coreboot/+/48528/comment/51ea4369_73700767 PS29, Line 156: $(OPT_VERSTAGE_FILE) \ : $(OPT_VERSTAGE_SIG_FILE) \ no verstage support yet, i'd remove those for now