Attention is currently required from: Bao Zheng, Martin Roth, Marshall Dawson.
6 comments:
File src/soc/amd/cezanne/Kconfig:
Patch Set #29, Line 163: config PSP_LOAD_MP2_FW
not sure if PSP_LOAD_MP2_FW and PSP_LOAD_S0I3_FW should be default y. for PSP_UNLOCK_SECURE_DEBUG i agree that it should be default y for now and changed back when we're done with the platform bring-up. i'm ok with keeping it as it is right now and have another look at it later
File src/soc/amd/cezanne/Makefile.inc:
Patch Set #29, Line 46: CONFIG_AMD_FWM_POSITION_INDEX
there should probably be a check to make sure that this isn't an empty string instead of the number and if it is empty throw an error. see https://docs.zephyrproject.org/1.14.0/guides/kconfig/index.html#redundant-defaults on the default of int in Kconfig.
same for picasso
Patch Set #29, Line 113: OPT_APOB_ADDR=$(call add_opt_prefix, $(PSP_APOB_BASE), --apob-base)
the other apob related things aren't in here, so i wonder if this one should also be removed for now and added back when the apob support is added
Patch Set #29, Line 137: $(OPT_SEC_DEBUG_FILE) \
this variable doesn't exist, so should probably be removed. same for picasso
Patch Set #29, Line 154: $(OPT_PSPBTLDR_FILE) \
this variable seems to be undefined, so i guess it can be removed. same for picasso
$(OPT_VERSTAGE_FILE) \
$(OPT_VERSTAGE_SIG_FILE) \
no verstage support yet, i'd remove those for now
To view, visit change 48528. To unsubscribe, or for help writing mail filters, visit settings.