Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h>
......................................................................
Patch Set 4: Code-Review-2
See CB:37842 comments, for now let's not add <pci_def.h> for PCI_SLOT() or PCI_DEVFN() et.al.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e062923f8b5501ab50b9af291b01241d17e122c
Gerrit-Change-Number: 37951
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Dec 2019 08:00:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment