Attention is currently required from: Patrick Rudolph, Richard Hughes, Maximilian Brune, Nicholas Chin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68995 )
Change subject: Documentation/sbom: Add SBOM Documentation ......................................................................
Patch Set 6:
(10 comments)
File Documentation/sbom/sbom.md:
https://review.coreboot.org/c/coreboot/+/68995/comment/b1be7670_abb02d22 PS6, Line 2: simply nit: omit "simply"
https://review.coreboot.org/c/coreboot/+/68995/comment/0276c4ce_51c9cf8d PS6, Line 4: much "many", because "software parts" is countable
[one would use "much" for uncountable things, like "water" and "time"]
https://review.coreboot.org/c/coreboot/+/68995/comment/9229f343_efd7242a PS6, Line 12: Systems Why is "Systems" capitalized?
https://review.coreboot.org/c/coreboot/+/68995/comment/6c6dec5d_e55cd49e PS6, Line 18: Image Why is "Image" capitalized?
https://review.coreboot.org/c/coreboot/+/68995/comment/9377252f_0420010d PS6, Line 92: CONFIG_SBOM_[software-name]_PATH You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. It also highlights that it's a Kconfig option
https://review.coreboot.org/c/coreboot/+/68995/comment/bb6c74df_bbb43b54 PS6, Line 103: CONFIG_SBOM_[software-name]_PATH=/path/to/me.bin You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. It also highlights that it's a Kconfig option
https://review.coreboot.org/c/coreboot/+/68995/comment/ee1eddfd_0ac9fab6 PS6, Line 116: The second solution should in general be preferred Why not place the preferred option first?
https://review.coreboot.org/c/coreboot/+/68995/comment/2a7a1ef2_6d9a9132 PS6, Line 116: The second solution should in general be preferred Why not place the preferred option first?
File Documentation/sbom/sbom_generation.plantuml:
PS6: What does this file do?
File Documentation/sbom/sbom_generation.png:
PS3:
Images should be kept small. […]
@Max: Given that this is a diagram, can you please make it a SVG?
@Nicolas: The file size is reasonable, although converting it to JPEG should make it smaller. SVG should be even better: it's essentially XML, so it works nicely with Git should the diagram need to be updated.