Attention is currently required from: Patrick Rudolph, Richard Hughes, Maximilian Brune, Nicholas Chin.
10 comments:
File Documentation/sbom/sbom.md:
Patch Set #6, Line 2: simply
nit: omit "simply"
"many", because "software parts" is countable
[one would use "much" for uncountable things, like "water" and "time"]
Patch Set #6, Line 12: Systems
Why is "Systems" capitalized?
Patch Set #6, Line 18: Image
Why is "Image" capitalized?
Patch Set #6, Line 92: CONFIG_SBOM_[software-name]\_PATH
You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. It also highlights that it's a Kconfig option
Patch Set #6, Line 103: CONFIG_SBOM_[software-name]\_PATH=/path/to/me.bin
You may want to wrap this in backticks ` so that Markdown doesn't try to do anything weird. It also highlights that it's a Kconfig option
Patch Set #6, Line 116: The second solution should in general be preferred
Why not place the preferred option first?
Patch Set #6, Line 116: The second solution should in general be preferred
Why not place the preferred option first?
File Documentation/sbom/sbom_generation.plantuml:
What does this file do?
File Documentation/sbom/sbom_generation.png:
> Images should be kept small. […]
@Max: Given that this is a diagram, can you please make it a SVG?
@Nicolas: The file size is reasonable, although converting it to JPEG should make it smaller. SVG should be even better: it's essentially XML, so it works nicely with Git should the diagram need to be updated.
To view, visit change 68995. To unsubscribe, or for help writing mail filters, visit settings.