Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44700 )
Change subject: soc/mediatek/mt8192: Do dramc init settings
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44700/10/src/soc/mediatek/mt8192/dr...
File src/soc/mediatek/mt8192/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/44700/10/src/soc/mediatek/mt8192/dr...
PS10, Line 5: #include <soc/mt6359p.h>
@Xi, as discussed, please use regulator API
https://review.coreboot.org/c/coreboot/+/44700/10/src/soc/mediatek/mt8192/dr...
PS10, Line 12: mt6359p_buck_set_voltage
ditto
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4877b69de1bfa4ff981d8eb386efbddb9e0f5c2
Gerrit-Change-Number: 44700
Gerrit-PatchSet: 10
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 23 Oct 2020 07:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment