Attention is currently required from: Nico Huber, Eugene Myers, Benjamin Doron, Paul Menzel, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 193:
(13 comments)
File src/mainboard/acer/aspire_vn7_572g/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/18dd5ab0_70bb8d0a PS193, Line 22: select NO_UART_ON_SUPERIO 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/fa3abdf3_776c1278 PS193, Line 45: if (data_buffer <= (2017 / ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/52b99255_5d5eb4f4 PS193, Line 302: | LPC_IOE_EC_62_66 | LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F" # 82h-83h 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/f57977e9_d2ab26bb PS193, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/52bb8649_3f9295b3 PS193, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/6d347160_facd159d PS193, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/8a3c8259_93778144 PS193, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/94c5936a_845a8ce3 PS193, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/1630294a_dece8d43 PS193, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/60899753_03da9f15 PS193, Line 98: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/5eaf140c_63e3e46f PS193, Line 122: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/85fb9757_c516d8b7 PS193, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135581): https://review.coreboot.org/c/coreboot/+/35523/comment/cc51af09_5a1d4c1f PS193, Line 160: if (gnvs) { braces {} are not necessary for single statement blocks