Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39360 )
Change subject: mb/google/dedede: Add ACPI support for camera ......................................................................
Patch Set 22:
(51 comments)
Marked the resolved comments as resolved.
https://review.coreboot.org/c/coreboot/+/39360/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39360/13//COMMIT_MSG@12 PS13, Line 12: Add ON and OFF logic as Power Rails are same for both sensor
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@7 PS16, Line 7: WDoo
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@9 PS16, Line 9: schmatics
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/16//COMMIT_MSG@13 PS16, Line 13:
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39360/21//COMMIT_MSG@7 PS21, Line 7: waddledoo
Updated.
Done
https://review.coreboot.org/c/coreboot/+/39360/21//COMMIT_MSG@13 PS21, Line 13:
Updated.
Done
https://review.coreboot.org/c/coreboot/+/39360/21//COMMIT_MSG@13 PS21, Line 13: : Signed-off-by: Pandya, Varshit B varshit.b.pandya@intel.com : Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com
Updated.
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 78: # Select this option to enable camera ACPI support on the variant.
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 81: default n
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... PS13, Line 85: Select this option to enable camera ACPI support on the variant
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... File src/mainboard/google/dedede/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 37: #if
please indent it to left
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 173:
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 180: 0
This GPIOs are controlled by the Kernel, so kept PLTRST
Done
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 304: PLTRST
DEEP
Done
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 306: PLTRST
DEEP
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 209: /* E6 : GPP_E6/IMGCLKOUT_3 */
No need to configure the straps. […]
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 221: /* E12 : GPP_E12/IMGCLKOUT_4 */
Same response as above. No need to configure the straps.
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 16: scope
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 19: Method
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 19: of
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 22: PP1200
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 24: PP2800
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 43: GPP_D12
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 51: //Enable PP1200 lane : STXS(GPP_D13) : //Enable PP2800 lane : STXS(GPP_D14)
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 55: Sleep(5)
Removed
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 72: MCOF
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 76: //Disable PP1200 lane : CTXS(GPP_D13) : //Disable PP2800 lane : CTXS(GPP_D14)
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 82: }
Kept this outside the IF/ELSE block
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 132: 0x02
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 19: // Method to turn off Power Rails
/* Method to turn off Power Rails */ […]
Done
https://review.coreboot.org/c/coreboot/+/39360/11/src/mainboard/google/deded... PS11, Line 29: // Enable PP2800 lane.
/* Enable PP2800 lane */
Done
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... PS13, Line 4: * Copyright (C) 2020 Intel Corporation.
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... PS13, Line 46: STXS(GPP_D15)
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... PS13, Line 54: Sleep(5)
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright (C) 2020 Intel Corporation : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ :
Updated.
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 18: Name (STA0, Zero)
Updated.
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 38: 0,1
Updated.
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 39: IF(STA1) : { : /* Power signal are already ON */ : /* Assert Reset */ : CTXS(GPP_D15) : Sleep(5) /* 5 us */ : /* Deassert Reset */ : STXS(GPP_D15) : Sleep(5) /* 5 us */ : } : ELSE : { : PON() : /* Assert Reset */ : CTXS(GPP_D15) : Sleep(5) /* 5 us */ : /* Deassert Reset */ : STXS(GPP_D15) : Sleep(5) /* 5 us */ : }
Updated.
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 59: Store(1,STA0)
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 66: IF(STA1) : { : /* Do nothing since the other sensor is ON */ : } : ELSE : { : POFF() : }
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 183: } : } : } : }) : }
Updated.
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 37: //Enable PP1200 lane : STXS(GPP_D13) : //Enable PP2800 lane : STXS(GPP_D14)
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 41: Sleep(5)
Removed
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 58: MCOF(1) // Clock 1
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 63: CTXS(GPP_D13) : //Disable PP2800 lane : CTXS(GPP_D14)
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/9/src/mainboard/google/dedede... PS9, Line 67: }
Done
Done
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... PS13, Line 4: * Copyright (C) 2020 Intel Corporation.
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
https://review.coreboot.org/c/coreboot/+/39360/15/src/mainboard/google/deded... PS15, Line 15:
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl:
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... PS13, Line 4: * Copyright (C) 2020 Intel Corporation.
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/13/src/mainboard/google/deded... PS13, Line 18: Name (EP00, Package (0x02)
Updated
Done
https://review.coreboot.org/c/coreboot/+/39360/20/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/waddledoo/include/variant/acpi/camera.asl:
PS20:
Updated
Done