Marked the resolved comments as resolved.
51 comments:
Patch Set #13, Line 12: Add ON and OFF logic as Power Rails are same for both sensor
Updated
Done
Updated
Done
Patch Set #16, Line 9: schmatics
Updated
Done
Updated
Done
Patch Set #21, Line 7: waddledoo
Updated.
Done
Updated.
Done
Signed-off-by: Pandya, Varshit B <varshit.b.pandya@intel.com>
Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com>
Updated.
Done
File src/mainboard/google/dedede/Kconfig:
Patch Set #9, Line 78: # Select this option to enable camera ACPI support on the variant.
Done
Done
Patch Set #9, Line 81: default n
Done
Done
File src/mainboard/google/dedede/Kconfig:
Patch Set #13, Line 85: Select this option to enable camera ACPI support on the variant
Updated
Done
File src/mainboard/google/dedede/dsdt.asl:
please indent it to left
Done
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
Done
Done
This GPIOs are controlled by the Kernel, so kept PLTRST
Done
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
Patch Set #11, Line 304: PLTRST
DEEP
Done
Patch Set #11, Line 306: PLTRST
DEEP
Done
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
Patch Set #15, Line 209: /* E6 : GPP_E6/IMGCLKOUT_3 */
No need to configure the straps. […]
Done
Patch Set #15, Line 221: /* E12 : GPP_E12/IMGCLKOUT_4 */
Same response as above. No need to configure the straps.
Done
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
Patch Set #9, Line 16: scope
Done
Done
Patch Set #9, Line 19: Method
Done
Done
Done
Done
Patch Set #9, Line 22: PP1200
Done
Done
Patch Set #9, Line 24: PP2800
Done
Done
Patch Set #9, Line 43: GPP_D12
Done
Done
//Enable PP1200 lane
STXS(GPP_D13)
//Enable PP2800 lane
STXS(GPP_D14)
Done
Done
Patch Set #9, Line 55: Sleep(5)
Removed
Done
Done
Done
//Disable PP1200 lane
CTXS(GPP_D13)
//Disable PP2800 lane
CTXS(GPP_D14)
Done
Done
Kept this outside the IF/ELSE block
Done
Done
Done
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
Patch Set #11, Line 19: // Method to turn off Power Rails
/* Method to turn off Power Rails */ […]
Done
Patch Set #11, Line 29: // Enable PP2800 lane.
/* Enable PP2800 lane */
Done
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
Patch Set #13, Line 4: * Copyright (C) 2020 Intel Corporation.
Updated
Done
Patch Set #13, Line 46: STXS(GPP_D15)
Updated
Done
Patch Set #13, Line 54: Sleep(5)
Updated
Done
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2020 Intel Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
Updated.
Done
Patch Set #15, Line 18: Name (STA0, Zero)
Updated.
Done
Updated.
Done
IF(STA1)
{
/* Power signal are already ON */
/* Assert Reset */
CTXS(GPP_D15)
Sleep(5) /* 5 us */
/* Deassert Reset */
STXS(GPP_D15)
Sleep(5) /* 5 us */
}
ELSE
{
PON()
/* Assert Reset */
CTXS(GPP_D15)
Sleep(5) /* 5 us */
/* Deassert Reset */
STXS(GPP_D15)
Sleep(5) /* 5 us */
}
Updated.
Done
Patch Set #15, Line 59: Store(1,STA0)
Updated
Done
IF(STA1)
{
/* Do nothing since the other sensor is ON */
}
ELSE
{
POFF()
}
Updated
Done
}
}
}
})
}
Updated.
Done
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
//Enable PP1200 lane
STXS(GPP_D13)
//Enable PP2800 lane
STXS(GPP_D14)
Done
Done
Patch Set #9, Line 41: Sleep(5)
Removed
Done
Patch Set #9, Line 58: MCOF(1) // Clock 1
Done
Done
CTXS(GPP_D13)
//Disable PP2800 lane
CTXS(GPP_D14)
Done
Done
Done
Done
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
Patch Set #13, Line 4: * Copyright (C) 2020 Intel Corporation.
Updated
Done
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
Updated
Done
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl:
Patch Set #13, Line 4: * Copyright (C) 2020 Intel Corporation.
Updated
Done
Patch Set #13, Line 18: Name (EP00, Package (0x02)
Updated
Done
File src/mainboard/google/dedede/variants/waddledoo/include/variant/acpi/camera.asl:
Updated
Done
To view, visit change 39360. To unsubscribe, or for help writing mail filters, visit settings.