Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38235 )
Change subject: intel/e7505,i82801dx: Remove wrapper spd_read_byte()
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38235/4/src/northbridge/intel/e7505...
File src/northbridge/intel/e7505/raminit.c:
https://review.coreboot.org/c/coreboot/+/38235/4/src/northbridge/intel/e7505...
PS4, Line 1286: smbus_read_byte(dimm_socket_address,
Even then, not replacing the function call would be worse (the code would rot)
I have some follow-up on the topic, I'll touch this then.
There is enough CAR to hold the entire SPDs instead, no need to read them individually.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a2d3043f77c9aa9c93b4718c5742fbd8d69b79f
Gerrit-Change-Number: 38235
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jan 2020 17:51:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Idwer Vollering
vidwer@gmail.com
Gerrit-MessageType: comment