Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46333 )
Change subject: mb/google/dedede: Add P-sensor for Boten
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede...
PS1, Line 12: #| I2C1 | Digitizer |
Conflict to https://review.coreboot.org/c/coreboot/+/45807 . And if really necessary for this change then please split to another CL since it is not what commit msg mentioned.
https://review.coreboot.org/c/coreboot/+/46333/1/src/mainboard/google/dedede...
PS1, Line 158: GPP_E11_IRQ
Could we check with SoC team about whether the GPIO config of this GP_E11 is correct or not?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46333
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70f303995b106cca9758b36ebcde112ebcc90950
Gerrit-Change-Number: 46333
Gerrit-PatchSet: 1
Gerrit-Owner: Alec Wang
alec.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gwendal Grignou
gwendal@chromium.org
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Kao
ben.kao@intel.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Oct 2020 12:58:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment