[coreboot-gerrit] [M] Change in coreboot[main]: cpu/x86: Move SMI GSMI calls entry to a common place

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.

Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83066?usp=email )

Change subject: cpu/x86: Move SMI GSMI calls entry to a common place
......................................................................

Patch Set 4: Code-Review+2

(2 comments)

Patchset:

PS4: 
Nice dedup!

File src/drivers/elog/gsmi.c:

https://review.coreboot.org/c/coreboot/+/83066/comment/e2e869f7_8783283b?usp... :
PS4, Line 148: &param
Wouldn't hurt to change the API to make it a simple u32 instead of a pointer.
Just comparing the calling sites, it looked like the semantics are change
(originally passing a pointer into the save state, now passing a pointer to
the stack.) But it doesn't matter as gsmi_exec() only reads it.