Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44228 )
Change subject: cpu/x86: Introduce `CPU_X86_LAPIC`
......................................................................
Patch Set 4:
It looks like all X86 coreboot supports have a lapic. All Intel CPU's have a lapic since the first pentium (P54 released in 1994 according to wikipedia) . Maybe you can just unconditionally include it with a comment that we probably won't support museum-worthy hardware?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44228
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f683ea7ba92c91117017ebc6ad063ec54902b0a
Gerrit-Change-Number: 44228
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Aug 2020 23:41:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment