Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47292 )
Change subject: mb/google/dedede/var/drawcia: Change elan USI touchscreen to level trigger
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47292/2/src/mainboard/google/dedede...
PS2, Line 202: ACPI_IRQ_LEVEL_LOW
Does this device use level triggered interrupts as per the datasheet? I think most ELAN devices use edge-triggered. So, want to make sure we are not working around some other problem.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47292
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25953a26142eb7a66781fef9bb98c719bab6297f
Gerrit-Change-Number: 47292
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 06 Nov 2020 17:21:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment