HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 6: Code-Review-1
(1 comment)
-1 as I'm not sure and somehow confused
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... File src/mainboard/advansus/a785e-i/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... PS6, Line 1128: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
Why did you choose to get rid of the _ADR objects instead of the _HID? I'm not saying it's incorrec […]
By my understanding, only some legacy devices do need an _ADR. Maybe I'm wrong, but I think that PCI0 need a _HID.
this said,I'm confused by the 'Note' at line #1123, does it mean that the PCI (slot 24) is not the PCI0? if so maybe it should be as Device(PCI0) { External (TOM1) External (TOM2) Name(_HID, EISAID("PNP0A03")) Device (PCI ??) { Name(_ADR, 0x00180000) ..... }