26 Feb
2021
26 Feb
'21
8:27 a.m.
Attention is currently required from: Felix Singer, Nico Huber, Benjamin Doron, Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 172: Code-Review+1
(1 comment)
Patchset:
PS172: Very nice. It’d be great if you wrapped the comments as the linter scripts commented, but the rest looks nice.
Out of curiosity, how did you create the ASL files?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35523
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 172
Gerrit-Owner: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 26 Feb 2021 07:27:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment