Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 67:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/62/src/mainboard/acer/aspire_... PS62, Line 240: device pci 01.0 on end # Dedicated Graphics Device
Yes, but that's not what I meant. While 01:00. […]
CB:39002 is about framebuffers that are set up by gfx-init drivers in coreboot. This is completely independent of the way a GPU is connected.
Trying to clear some confusion, I hope I won't make it worse: PEG (PCI Express for Graphics) generally refers to a slot on a mainboard that is dedicated for the gfx card. Sometimes, in the Intel-firmware context it also refers to the PCIe lanes (pins) of the CPU package (what Angel meant). This would show up as `pci 01.0` on bus 0, but SKL-U doesn't have these pins, so there is no `pci 01.0`. Some PCIe lanes of the PCH are used instead, that's all. It makes no difference for Optimus, no difference to gfx drivers, no difference for framebuffers. It's just the way it's physically connected, but that doesn't change anything for the software (beside that coreboot has to enable whatever PCIe port it is connected to).
It's better not to use the term PEG if one doesn't mean a physically present connector (if it's absent how could it be dedicated to gfx?).