Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49184 )
Change subject: mb/asrock/h110m: Fix HECI state in devicetree
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49184/comment/3b183ef1_cb3698c3
PS3, Line 9: making its state equal with the HeciEnabled
: option
Should we? It depends on the point in coreboot when `HeciEnabled`
is committed. If that happens before PCI enumeration, the devicetree
should match (otherwise we'd get a warning about 16.0, easy to check).
But if it happens later, different values could still be meaningful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49184
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67a9f0a66bcc51c6153a76bfaaebdf1e7f07d55d
Gerrit-Change-Number: 49184
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Thu, 07 Jan 2021 19:58:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment