Attention is currently required from: Elyes Haouas, Paul Menzel.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email )
Change subject: device/azalia: Clean up codec initialization code ......................................................................
Patch Set 5:
(4 comments)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/80332/comment/398e3436_ed399339 : PS5, Line 9: stdbool.h
types. […]
Done
https://review.coreboot.org/c/coreboot/+/80332/comment/ff7fa7b7_65d0bd2b : PS5, Line 230: static bool
is "enum cb_err" can be used ? […]
Done
https://review.coreboot.org/c/coreboot/+/80332/comment/7a42fc7e_e81eef14 : PS5, Line 249: u32
Please, is "size_t' correct here?
Yes, I agree this should be `size_t`. If I'm going to change this here, I would also like to change all the other `u32`s that should be `size_t` in this file. However that seems like a bit too much and would be better in a separate patch.
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80332/comment/1d6ee167_206aa4bf : PS5, Line 13:
not sure, but I think those are intentional (same for line #18 & 19)
Hmmm, I think I see the intention here, do you think it would be better keeping this? I would be leaning more on the "not necessary" side.