Attention is currently required from: Elyes Haouas, Paul Menzel.
4 comments:
File src/device/azalia_device.c:
Patch Set #5, Line 9: stdbool.h
types. […]
Done
Patch Set #5, Line 230: static bool
is "enum cb_err" can be used ? […]
Done
Please, is "size_t' correct here?
Yes, I agree this should be `size_t`.
If I'm going to change this here, I would also like to change all the other `u32`s that should be `size_t` in this file. However that seems like a bit too much and would be better in a separate patch.
File src/include/device/azalia_device.h:
not sure, but I think those are intentional (same for line #18 & 19)
Hmmm, I think I see the intention here, do you think it would be better keeping this? I would be leaning more on the "not necessary" side.
To view, visit change 80332. To unsubscribe, or for help writing mail filters, visit settings.