[coreboot-gerrit] [XS] Change in coreboot[main]: acpi: Fix return value in acpi_device_write_dsd_gpio()

[Paul Menzel (Code Review)]

Attention is currently required from: Jianeng Ceng, Paul Menzel.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email )

Change subject: acpi: Fix return value in acpi_device_write_dsd_gpio()
......................................................................

Patch Set 6: Code-Review+1

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82088/comment/3b7a15c9_521bedc6 :
PS6, Line 11: The error was introduced in the commit making it public:
Blank line above.

https://review.coreboot.org/c/coreboot/+/82088/comment/ad1f95ec_accfa204 :
PS6, Line 11: The error was introduced in the commit making it public:
            : commit 01344bce
Maybe:

Commit 01344bce1a60 (acpi: Make acpi_device_write_dsd_gpio() public) introduced the error by removing the parentheses, when refactoring the assignment.

https://review.coreboot.org/c/coreboot/+/82088/comment/2dae7e18_09c886d0 :
PS6, Line 16: 
Maybe even add the tag below (although we have no policy to this effect):

Fixes: 01344bce1a60 ("acpi: Make acpi_device_write_dsd_gpio() public")

Patchset:

PS6: 
Feel free to address my nitpicks or to ignore them.