Attention is currently required from: Jianeng Ceng, Paul Menzel.

Patch set 6:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #6, Line 11: The error was introduced in the commit making it public:

    Blank line above.

  • Patch Set #6, Line 11:

    The error was introduced in the commit making it public:
    commit 01344bce
    

    Maybe:

    Commit 01344bce1a60 (acpi: Make acpi_device_write_dsd_gpio() public) introduced the error by removing the parentheses, when refactoring the assignment.

  • Patch Set #6, Line 16:

    Maybe even add the tag below (although we have no policy to this effect):

    Fixes: 01344bce1a60 ("acpi: Make acpi_device_write_dsd_gpio() public")

• Patchset:

  • Patch Set #6:

    Feel free to address my nitpicks or to ignore them.

To view, visit change 82088. To unsubscribe, or for help writing mail filters, visit settings.