Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38346 )
Change subject: mainboard: add Supermicro X9SCL/X9SCM ......................................................................
Patch Set 11: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x9scl/acpi/platform.asl:
PS10:
/* SPDX-License-Identifier: GPL-2.0-or-later */ […]
Done
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x9scl/acpi/superio.asl:
PS10:
/* SPDX-License-Identifier: GPL-2.0-or-later */ […]
Done
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x9scl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... PS10, Line 122: end
Maybe pick these up?
Done
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x9scl/dsdt.asl:
PS10:
/* SPDX-License-Identifier: GPL-2.0-or-later */ […]
Done
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... PS10, Line 36: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
Not needed anymore
Done