Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42311 )
Change subject: tests: Complete lib/string-test test case ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@48 PS1, Line 48: uint32_t
I based choice of function return type on an already existing atoi implementation from src/lib/strin […]
You always need to mark all comments as "Resolved" before Gerrit allows us to merge something. You can check the "Comment Threads" -> "Only unresolved threads" view to see what's still missing.
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@190 PS1, Line 190: assert_int_equal
Until we determine (see one of comments above) whether to keep the unsigned int type or change to si […]
Done
https://review.coreboot.org/c/coreboot/+/42311/1/tests/lib/string-test.c@191 PS1, Line 191: }
I suppose that confirmation of the update is still possible with this implementation. […]
Done