3 comments:
Patch Set #1, Line 48: uint32_t
I based choice of function return type on an already existing atoi implementation from src/lib/strin […]
You always need to mark all comments as "Resolved" before Gerrit allows us to merge something. You can check the "Comment Threads" -> "Only unresolved threads" view to see what's still missing.
Patch Set #1, Line 190: assert_int_equal
Until we determine (see one of comments above) whether to keep the unsigned int type or change to si […]
Done
I suppose that confirmation of the update is still possible with this implementation. […]
Done
To view, visit change 42311. To unsubscribe, or for help writing mail filters, visit settings.