Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31503 )
Change subject: drivers/intel/gma: Add `new-pch.asl` for Skylake+
......................................................................
Patch Set 1:
b) The TRAP only makes sense if there is an SMI handler to handle it. Maybe we
should identify the platforms that do that and disable the call on the others.
It's smitraphandler.c and smihandler.c, I presume?
"IOTRAP(1) currently unused" (https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...).
I looked through the tree and it definitely seems as though this line has only been inherited from prior southbridges and SoCs, but it isn't used anywhere.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b21d9a0288f0f8d6cb0a4776909bffdae7576f5
Gerrit-Change-Number: 31503
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Mar 2020 00:29:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment