b) The TRAP only makes sense if there is an SMI handler to handle it. Maybe we
should identify the platforms that do that and disable the call on the others.

It's smitraphandler.c and smihandler.c, I presume?

"IOTRAP(1) currently unused" (https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/smm/smitraphandler.c#L101).

I looked through the tree and it definitely seems as though this line has only been inherited from prior southbridges and SoCs, but it isn't used anywhere.

View Change

To view, visit change 31503. To unsubscribe, or for help writing mail filters, visit settings.