Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31462 )
Change subject: intel/apollolake: mark mapped BIOS region as reserved ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
Patch Set 2:
Shouldn't this be covered by a generic region over the whole flash?
Makes sense.
https://review.coreboot.org/#/c/31462/3/src/soc/intel/apollolake/mmap_boot.c File src/soc/intel/apollolake/mmap_boot.c:
https://review.coreboot.org/#/c/31462/3/src/soc/intel/apollolake/mmap_boot.c... PS3, Line 156: bootmem_add_range(0x100000000 - size, size, BM_MEM_RESERVED); This is going to create a problem for anything in OS that relies on memory mapping of the SPI flash. It could break some tools. None of other intel platforms mark the SPI flash region as reserved.