Change in ...coreboot[master]: intel/apollolake: mark read only SRAM as reserved

[Christian Gmeiner (Code Review)]

Christian Gmeiner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31462

Change subject: intel/apollolake: mark read only SRAM as reserved
......................................................................

intel/apollolake: mark read only SRAM as reserved

Change-Id: I0ccb40f30e8596b3f57e30901efdbd5d6f9529f1
Signed-off-by: Christian Gmeiner 
---
M src/soc/intel/apollolake/mmap_boot.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/31462/1

diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c
index 1c3077e..a1de8ea 100644
--- a/src/soc/intel/apollolake/mmap_boot.c
+++ b/src/soc/intel/apollolake/mmap_boot.c
@@ -18,6 +18,7 @@

#include <arch/early_variables.h>
 #include <boot_device.h>
+#include <bootmem.h>
 #include <cbfs.h>
 #include <commonlib/region.h>
 #include <console/console.h>
@@ -146,3 +147,11 @@
    .name = "IAFW Locator",
    .locate = iafw_boot_region_properties,
 };
+
+void bootmem_platform_add_ranges(void)
+{
+	const int size = 256 * KiB;
+
+	/* read only SRAM */
+	bootmem_add_range(0x100000000 - size, size, BM_MEM_RESERVED);
+}
\ No newline at end of file

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31462 )

Change subject: intel/apollolake: mark read only SRAM as reserved
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31462/1/src/soc/intel/apollolake/mmap_boot.c 
File src/soc/intel/apollolake/mmap_boot.c:

https://review.coreboot.org/#/c/31462/1/src/soc/intel/apollolake/mmap_boot.c... 
PS1, Line 157: }
adding a line without newline at end of file

[Christian Gmeiner (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31462

to look at the new patch set (#2).

Change subject: intel/apollolake: mark read only SRAM as reserved
......................................................................

intel/apollolake: mark read only SRAM as reserved

Change-Id: I0ccb40f30e8596b3f57e30901efdbd5d6f9529f1
Signed-off-by: Christian Gmeiner 
---
M src/soc/intel/apollolake/mmap_boot.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/31462/2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31462 )

Change subject: intel/apollolake: mark read only SRAM as reserved
......................................................................

Patch Set 2:

Shouldn't this be covered by a generic region over the whole flash?

Change in ...coreboot[master]: intel/apollolake: mark mapped BIOS region as reserved

[Christian Gmeiner (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31462

to look at the new patch set (#3).

Change subject: intel/apollolake: mark mapped BIOS region as reserved
......................................................................

intel/apollolake: mark mapped BIOS region as reserved

Change-Id: I0ccb40f30e8596b3f57e30901efdbd5d6f9529f1
Signed-off-by: Christian Gmeiner 
---
M src/soc/intel/apollolake/mmap_boot.c
1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/31462/3

Change in ...coreboot[master]: intel/apollolake: mark mapped BIOS region as reserved

[Christian Gmeiner (Code Review)]

Christian Gmeiner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31462 )

Change subject: intel/apollolake: mark mapped BIOS region as reserved
......................................................................

Patch Set 3:
> Patch Set 2:
>
> Shouldn't this be covered by a generic region over the whole flash?

Makes sense.

Change in ...coreboot[master]: intel/apollolake: mark mapped BIOS region as reserved

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31462 )

Change subject: intel/apollolake: mark mapped BIOS region as reserved
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 3:
> > Patch Set 2:
> >
> > Shouldn't this be covered by a generic region over the whole flash?
>
> Makes sense.

https://review.coreboot.org/#/c/31462/3/src/soc/intel/apollolake/mmap_boot.c 
File src/soc/intel/apollolake/mmap_boot.c:

https://review.coreboot.org/#/c/31462/3/src/soc/intel/apollolake/mmap_boot.c... 
PS3, Line 156: bootmem_add_range(0x100000000 - size, size, BM_MEM_RESERVED);
This is going to create a problem for anything in OS that relies on memory mapping of the SPI flash. It could break some tools. None of other intel platforms mark the SPI flash region as reserved.

[XS] Change in coreboot[master]: intel/apollolake: mark mapped BIOS region as reserved

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31462?usp=email )

Change subject: intel/apollolake: mark mapped BIOS region as reserved
......................................................................

Abandoned