3 Feb
2020
3 Feb
'20
12:16 p.m.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ......................................................................
Patch Set 25:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp101_board.jpg:
PS25:
Oh, I love the idea! It clearly shows where the flash chip is. Two questions, though: […]
I also added MBA 5,2 documentation with similar motherboard view.
- OK - Well, yes, but actually they are not marked just because you don't need them to flash coreboot. Users are already confused enough, so I marked only what's necessary :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/32673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica03aba442493c0d369a3d360ad569ddc16954df
Gerrit-Change-Number: 32673
Gerrit-PatchSet: 25
Gerrit-Owner: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Feb 2020 12:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evgeny Zinoviev me@ch1p.io
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment