Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35523/14/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/14/src/mainboard/acer/aspire_... PS14, Line 51: config CPU_MICROCODE_CBFS_LEN Is this the length of one microcode or the whole blob? How likely is it to change in the future?
https://review.coreboot.org/c/coreboot/+/35523/14/src/mainboard/acer/aspire_... PS14, Line 59: config CBFS_SIZE Assuming that CBFS can be $flash_size - ($intel_descriptor + $intel_ME), this is now correct. (but isn't ME only 1.5MB, just padded out to 2MB?)