Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33065 )
Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33065/1/src/soc/intel/apollolake/Kconfig
File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/#/c/33065/1/src/soc/intel/apollolake/Kconfig@369
PS1, Line 369: depends on DRIVERS_UART_8250MEM_32
: depends on CONSOLE_SERIAL
Are the addresses specific to the SoC internal UARTS?
Then I'd suggest `depends on INTEL_LPSS_UART_FOR_CONSOLE`
instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32c18aa6f767cfaf14e3b86796d7d7a32ff1d3d5
Gerrit-Change-Number: 33065
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 29 May 2019 14:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment