Change in ...coreboot[master]: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33065

Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................

soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS

Set CONSOLE_UART_BASE_ADDRESS for SoC's internal UART.
Allows to build SeaBios without manually specifying the MMIO address.

Tested on Up squared: The serial works in SeaBios.

Change-Id: I32c18aa6f767cfaf14e3b86796d7d7a32ff1d3d5
Signed-off-by: Patrick Rudolph 
---
M src/soc/intel/apollolake/Kconfig
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/33065/1

diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig
index 217d1ea..bce276c 100644
--- a/src/soc/intel/apollolake/Kconfig
+++ b/src/soc/intel/apollolake/Kconfig
@@ -361,6 +361,14 @@
    int
    default 100

+config CONSOLE_UART_BASE_ADDRESS
+	hex
+	default 0xddffc000 if UART_FOR_CONSOLE = 0
+	default 0xddffe000 if UART_FOR_CONSOLE = 1
+	default 0xde000000 if UART_FOR_CONSOLE = 2
+	depends on DRIVERS_UART_8250MEM_32
+	depends on CONSOLE_SERIAL
+
 config APL_SKIP_SET_POWER_LIMITS
    bool
    default n

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33065 )

Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33065/1/src/soc/intel/apollolake/Kconfig 
File src/soc/intel/apollolake/Kconfig:

https://review.coreboot.org/#/c/33065/1/src/soc/intel/apollolake/Kconfig@369 
PS1, Line 369: depends on DRIVERS_UART_8250MEM_32
             : 	depends on CONSOLE_SERIAL
Are the addresses specific to the SoC internal UARTS?
Then I'd suggest `depends on INTEL_LPSS_UART_FOR_CONSOLE`
instead.

[Patrick Rudolph (Code Review)]

Hello Felix Singer, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33065

to look at the new patch set (#2).

Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................

soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS

Set CONSOLE_UART_BASE_ADDRESS for SoC's internal UART.
Allows to build SeaBios without manually specifying the MMIO address.

Tested on Up squared: The serial works in SeaBios.

Change-Id: I32c18aa6f767cfaf14e3b86796d7d7a32ff1d3d5
Signed-off-by: Patrick Rudolph 
---
M src/soc/intel/apollolake/Kconfig
1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/33065/2

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33065 )

Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33065/1/src/soc/intel/apollolake/Kconfig 
File src/soc/intel/apollolake/Kconfig:

https://review.coreboot.org/#/c/33065/1/src/soc/intel/apollolake/Kconfig@369 
PS1, Line 369: depends on DRIVERS_UART_8250MEM_32
             : 	depends on CONSOLE_SERIAL
> Are the addresses specific to the SoC internal UARTS? […]

Done

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33065 )

Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33065/2/src/soc/intel/apollolake/Kconfig 
File src/soc/intel/apollolake/Kconfig:

https://review.coreboot.org/#/c/33065/2/src/soc/intel/apollolake/Kconfig@367 
PS2, Line 367: 0xddffe000
Use the define in iomap.h instead of hard coding here?

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33065 )

Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33065/2/src/soc/intel/apollolake/Kconfig 
File src/soc/intel/apollolake/Kconfig:

https://review.coreboot.org/#/c/33065/2/src/soc/intel/apollolake/Kconfig@367 
PS2, Line 367: 0xddffe000
> Use the define in iomap. […]

It wouldn't work as CONSOLE_UART_BASE_ADDRESS is used outside
of C (you can pass numbers from Kconfig to C but not the other
way around).

I have tried to clean the redundancy up in a different way,
get rid of the definitions in `iomap.h`: topic:lpss_console_cleanup

[Patrick Rudolph (Code Review)]

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33065 )

Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................

Abandoned