Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36430 )
Change subject: arch/acpi.h: Avoid explicitly assign values to enum names ......................................................................
Patch Set 2:
Patch Set 2:
Hm, I'm not too sure about this: these values are exported to outside consumers and so I think there's value making them explicit. Otherwise some future developer might decide to reorder the entries alphabetically, or add an entry somewhere in between.
Yes, I understand your point but in my opinion,the concept of enum is very basic. Though considering the case, there is still no particular convention we are following in coreboot for this as here on line:783, only initial value is assigned, which again, being 0, is not a necessity. And we can see a lot of instances where different approaches are applied. I am just trying to provide a better readability for only consecutive entries.