Patch Set 2:

Hm, I'm not too sure about this: these values are exported to outside consumers and so I think there's value making them explicit. Otherwise some future developer might decide to reorder the entries alphabetically, or add an entry somewhere in between.

Yes, I understand your point but in my opinion,the concept of enum is very basic. Though considering the case, there is still no particular convention we are following in coreboot for this as here on line:783, only initial value is assigned, which again, being 0, is not a necessity. And we can see a lot of instances where different approaches are applied.
I am just trying to provide a better readability for only consecutive entries.

View Change

To view, visit change 36430. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5aa9762051780b67013f67f101112fc7a0bf6e
Gerrit-Change-Number: 36430
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 01 Nov 2019 12:49:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment