Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 179:
(21 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/6b154d13_33d41c3a PS179, Line 45: if (data_buffer <= (2017/ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/die.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/563271dd_37aafe01 PS179, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/ec.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/989250b7_60c0b3ad PS179, Line 27: #define EC_INDEX_IO_HIGH_ADDR_PORT EC_INDEX_IO_PORT+1 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/35523/comment/826607f8_0c6d04e6 PS179, Line 28: #define EC_INDEX_IO_LOW_ADDR_PORT EC_INDEX_IO_PORT+2 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/35523/comment/b884092e_fd0d815d PS179, Line 29: #define EC_INDEX_IO_DATA_PORT EC_INDEX_IO_PORT+3 Macros with complex values should be enclosed in parentheses
File src/mainboard/acer/aspire_vn7_572g/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/64291b8f_2c364160 PS179, Line 73: 0x0143b000, /* Set amplifier gain on speaker: Set output, L+R amp; Unmuted; No gain */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/comment/a331d1b6_db15702f PS179, Line 75: 0x01470740, /* Set widget control on speaker: Out enabled; VrefEn: Hi-Z (disabled) */ line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/47835a2f_4fb010d8 PS179, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/d2328601_3f433015 PS179, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/67b8c371_6e02795e PS179, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/bcc425b7_ee97a2c1 PS179, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/05e8d33d_ff31c894 PS179, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/7f8d097e_9796125f PS179, Line 97: if (dat & 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/28f24573_a77a9edc PS179, Line 120: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35523/comment/040b9dab_ec585d3e PS179, Line 130: /* Clear xHCI PM_CS[PME_Status] - RW/1C - and disable xHCI PM_CS[PME_En] */ line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/c021c993_706d97d0 PS179, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/f84df7ed_173b0ee4 PS179, Line 51: switch (gnvs->unused_was_osys) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/35523/comment/2db73dac_80c762dc PS179, Line 85: switch (function_parameter_0) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/35523/comment/db90992f_7aa44c18 PS179, Line 120: function_parameter_0 = smm_data_port &~ 0xF0; need consistent spacing around '&' (ctx:WxO)
https://review.coreboot.org/c/coreboot/+/35523/comment/9747c219_11e6173a PS179, Line 120: function_parameter_0 = smm_data_port &~ 0xF0; space prohibited after that '~' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/35523/comment/a6c694b6_fa0a2959 PS179, Line 123: printk(BIOS_DEBUG, "Function 0x%x(0x%x, 0x%x) called\n", smif, function_parameter_0, function_parameter_1); line over 96 characters