[coreboot-gerrit] Change in coreboot[master]: mb/acer: Add Acer Aspire VN7-572G

[Benjamin Doron (Code Review)]

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )

Change subject: mb/acer: Add Acer Aspire VN7-572G
......................................................................

Patch Set 99:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35523/99/src/mainboard/acer/aspire_... 
File src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl:

https://review.coreboot.org/c/coreboot/+/35523/99/src/mainboard/acer/aspire_... 
PS99, Line 96: Device (SLPB)
             : 	{
             : 		Name (_HID, EisaId ("PNP0C0E") /* Sleep Button Device */)  // _HID: Hardware ID
             : 		Name (_PRW, Package (0x02)  // _PRW: Power Resources for Wake
             : 		{
             : 			0x0A,
             : 			0x03
             : 		})
             : 	}
> Is this generic device actually needed, or can the fixed sleep button be used?

ACPI may standardise the sleep button, but isn't the interrupt/GPIO ("0x0A") still somewhat board/SoC specific?