Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33059 )
Change subject: drivers/spi: add issi flash support ......................................................................
Patch Set 8: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/33059/8/src/drivers/spi/issi.c File src/drivers/spi/issi.c:
https://review.coreboot.org/c/coreboot/+/33059/8/src/drivers/spi/issi.c@53 PS8, Line 53: static int issi_flash_cmd_read(const struct spi_flash *flash, not required
https://review.coreboot.org/c/coreboot/+/33059/8/src/drivers/spi/issi.c@70 PS8, Line 70: static const struct spi_flash_ops spi_flash_ops = { move to bottom of file to get rid of function prototypes.
https://review.coreboot.org/c/coreboot/+/33059/8/src/drivers/spi/issi.c@140 PS8, Line 140: static int issi_do_write_cmd(const struct spi_flash *flash, use spi_flash_cmd