Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33059 ) Change subject: drivers/spi: add issi flash support ...................................................................... Patch Set 8: Code-Review+1 (3 comments) https://review.coreboot.org/c/coreboot/+/33059/8/src/drivers/spi/issi.c File src/drivers/spi/issi.c: https://review.coreboot.org/c/coreboot/+/33059/8/src/drivers/spi/issi.c@53 PS8, Line 53: static int issi_flash_cmd_read(const struct spi_flash *flash, not required https://review.coreboot.org/c/coreboot/+/33059/8/src/drivers/spi/issi.c@70 PS8, Line 70: static const struct spi_flash_ops spi_flash_ops = { move to bottom of file to get rid of function prototypes. https://review.coreboot.org/c/coreboot/+/33059/8/src/drivers/spi/issi.c@140 PS8, Line 140: static int issi_do_write_cmd(const struct spi_flash *flash, use spi_flash_cmd -- To view, visit https://review.coreboot.org/c/coreboot/+/33059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35c81f7afd4c2c4a52730eeb15ce0b55d8d6af60 Gerrit-Change-Number: 33059 Gerrit-PatchSet: 8 Gerrit-Owner: Xiang Wang <merle@hardenedlinux.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Xiang Wang <merle@hardenedlinux.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 02 Aug 2019 11:24:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment