Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35230 )
Change subject: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib. ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@2 PS2, Line 2: sridhar Please configure your full name.
$ git config -g user.name "…" $ git commit --amend --author="… <…@…>"
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@7 PS2, Line 7: src/soc/intel/common/block/cse: Add print_me_fw_version() to cse lib. Please remove the dot at the end.
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@12 PS2, Line 12: Tested how?
https://review.coreboot.org/c/coreboot/+/35230/2//COMMIT_MSG@15 PS2, Line 15: sridhar Full name please.
https://review.coreboot.org/c/coreboot/+/35230/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35230/2/src/soc/intel/common/block/... PS2, Line 89: #define MKHI_GET_FW_VERSION 0x02 Alignment seems off.