Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47707 )
Change subject: mb/intel/ehlcrb: Add initial mainboard code ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47707/4/src/mainboard/intel/elkhart... File src/mainboard/intel/elkhartlake_crb/board_info.txt:
https://review.coreboot.org/c/coreboot/+/47707/4/src/mainboard/intel/elkhart... PS4, Line 6: Flashrom support: y
Well, support for the SPI chip itself does not mean that flashrom is aware of the new PCI device ID […]
Make sense. Removed it
https://review.coreboot.org/c/coreboot/+/47707/4/src/mainboard/intel/elkhart... File src/mainboard/intel/elkhartlake_crb/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47707/4/src/mainboard/intel/elkhart... PS4, Line 33: sku2147483647
OK, let's not forget about it in the follow-up patches.
Done, already fixed in the coming patch: https://review.coreboot.org/c/coreboot/+/48123/1
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... File src/mainboard/intel/elkhartlake_crb/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... PS6, Line 11: 3 sets of functions
I guess you can write here "the next 3 functions" as the "set" was intending a couple of functions a […]
Done