Attention is currently required from: Alexander Couzens, Felix Held, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82070?usp=email )
Change subject: mb/lenovo/*: Set VR12 PSI to fix crash ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82070/comment/a36d2a8b_7998b666 : PS1, Line 13: as the vendor BIOS does to fix a hang when the package is idle. IIRC from CB:81597 review, you want boards to always specify these values. If so, then you should highly consider extending `util/autoport` to automatically read the relevant registers and write the values into the devicetree.
https://review.coreboot.org/c/coreboot/+/82070/comment/39b2843c_e6f2e9d0 : PS1, Line 14:
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/82070/comment/a381ffea_a54b873b : PS1, Line 19: The X220 already has the correct PSI values configured and is now stable Was this change tested on the other boards?
File src/mainboard/lenovo/l520/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82070/comment/f5075e8d_2e4d679d : PS1, Line 17: register "pp0_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}" : register "pp0_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}" : register "pp1_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}" : register "pp1_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}" If I get bored I will refactor this to use a 2D array:
``` register "pp_psi" = "{ [0] = { [VR12_PSI2] = {VR12_ALL_PHASES, 5}, [VR12_PSI3] = {VR12_ALL_PHASES, 1}, }, [1] = { [VR12_PSI2] = {VR12_ALL_PHASES, 5}, [VR12_PSI3] = {VR12_ALL_PHASES, 1}, }, }" ```