Attention is currently required from: Alexander Couzens, Felix Held, Patrick Rudolph.
Patch set 1:Code-Review +1
4 comments:
Commit Message:
Patch Set #1, Line 13: as the vendor BIOS does to fix a hang when the package is idle.
IIRC from CB:81597 review, you want boards to always specify these values. If so, then you should highly consider extending `util/autoport` to automatically read the relevant registers and write the values into the devicetree.
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
Patch Set #1, Line 19: The X220 already has the correct PSI values configured and is now stable
Was this change tested on the other boards?
File src/mainboard/lenovo/l520/devicetree.cb:
register "pp0_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp0_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
register "pp1_psi[VR12_PSI2]" = "{VR12_ALL_PHASES, 5}"
register "pp1_psi[VR12_PSI3]" = "{VR12_ALL_PHASES, 1}"
If I get bored I will refactor this to use a 2D array:
```
register "pp_psi" = "{
[0] = {
[VR12_PSI2] = {VR12_ALL_PHASES, 5},
[VR12_PSI3] = {VR12_ALL_PHASES, 1},
},
[1] = {
[VR12_PSI2] = {VR12_ALL_PHASES, 5},
[VR12_PSI3] = {VR12_ALL_PHASES, 1},
},
}"
```
To view, visit change 82070. To unsubscribe, or for help writing mail filters, visit settings.