[coreboot-gerrit] Change in coreboot[master]: soc/mediatek: Add PCIe support

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Arthur Heymans, Shelley Chen, Nico Huber, Furquan Shaikh, Paul Menzel, Angel Pons, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56791 )

Change subject: soc/mediatek: Add PCIe support
......................................................................

Patch Set 12:

(5 comments)

File src/soc/mediatek/common/include/soc/pcie_common.h:

https://review.coreboot.org/c/coreboot/+/56791/comment/d50655e2_2c2ecb7e 
PS11, Line 19: 	void (*reset)( uintptr_t base, bool enable);
> space prohibited after that open parenthesis '('

Please fix.

https://review.coreboot.org/c/coreboot/+/56791/comment/0e3f6ba7_f68b4b7f 
PS11, Line 25: domain
dev

Same for other instances in pcie.c.

File src/soc/mediatek/common/pcie.c:

https://review.coreboot.org/c/coreboot/+/56791/comment/5fa6470b_e6434949 
PS10, Line 120: val = read32(ctrl->base + PCIE_SETTING_REG);
              : 	val |= PCIE_RC_MODE;
              : 	write32(ctrl->base + PCIE_SETTING_REG, val);
> I use write32p() instead, is that OK?

Ack

File src/soc/mediatek/common/pcie.c:

https://review.coreboot.org/c/coreboot/+/56791/comment/ec044bbc_f3128b48 
PS11, Line 3: arch
device

Please remember to sort the headers.

https://review.coreboot.org/c/coreboot/+/56791/comment/16882ba9_4ffc9833 
PS11, Line 197: mtk_pcie_domain_set_resources
Maybe put this below mtk_pcie_domain_read_resources() to follow the calling order.