Attention is currently required from: Hung-Te Lin, Arthur Heymans, Shelley Chen, Nico Huber, Furquan Shaikh, Paul Menzel, Angel Pons, Jianjun Wang.

View Change

5 comments:

• File src/soc/mediatek/common/include/soc/pcie_common.h:

  • Patch Set #11, Line 19: void (*reset)( uintptr_t base, bool enable);

    space prohibited after that open parenthesis '('

    Please fix.

  • Patch Set #11, Line 25: domain

    dev

    Same for other instances in pcie.c.

• File src/soc/mediatek/common/pcie.c:

  • Patch Set #10, Line 120:

    val = read32(ctrl->base + PCIE_SETTING_REG);
    	val |= PCIE_RC_MODE;
    	write32(ctrl->base + PCIE_SETTING_REG, val);
    

    I use write32p() instead, is that OK?

    Ack

• File src/soc/mediatek/common/pcie.c:

  • Patch Set #11, Line 3: arch

    device

    Please remember to sort the headers.

  • Patch Set #11, Line 197: mtk_pcie_domain_set_resources

    Maybe put this below mtk_pcie_domain_read_resources() to follow the calling order.

To view, visit change 56791. To unsubscribe, or for help writing mail filters, visit settings.