Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard ......................................................................
Patch Set 15:
(7 comments)
https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@11 PS15, Line 11: Tested: You can make this look more like a list:
Tested: - Restart ... - Network ...
https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@13 PS15, Line 13: resume S3 resume?
https://review.coreboot.org/c/coreboot/+/40813/15//COMMIT_MSG@16 PS15, Line 16: i Capitalize
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... PS14, Line 8: /* Disable USB ports in S3 by default */ : gnvs->s3u0 = 0; : gnvs->s3u1 = 0; : /* Disable USB ports in S5 by default */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0;
So must I remove all line and let a blank function or revmove everthing an let an empty file?
You can check other mainboards, I think they just leave the function empty
https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... PS15, Line 18: Host bridge Host bridge Oh, didn't notice that this comment is duplicated
https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/40813/15/src/mainboard/ongy/h61m-s1... PS15, Line 13: Analog, Tiiiny detail: the port values are aligned with an extra space:
ports : constant Port_List := (HDMI1, Analog, others => Disabled);
https://review.coreboot.org/c/coreboot/+/40813/14/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/mainboard.c:
PS14:
You mean remove everything? My first build was with libgfxinit indeed
Yes, I never needed it with libgfxinit