7 comments:
Patch Set #15, Line 11: Tested:
You can make this look more like a list:
Tested:
- Restart ...
- Network ...
Patch Set #15, Line 13: resume
S3 resume?
Capitalize
File src/mainboard/ongy/h61m-s1/acpi_tables.c:
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
So must I remove all line and let a blank function or revmove everthing an let an empty file?
You can check other mainboards, I think they just leave the function empty
File src/mainboard/ongy/h61m-s1/devicetree.cb:
Patch Set #15, Line 18: Host bridge Host bridge
Oh, didn't notice that this comment is duplicated
File src/mainboard/ongy/h61m-s1/gma-mainboard.ads:
Patch Set #15, Line 13: Analog,
Tiiiny detail: the port values are aligned with an extra space:
ports : constant Port_List :=
(HDMI1,
Analog,
others => Disabled);
File src/mainboard/ongy/h61m-s1/mainboard.c:
You mean remove everything? My first build was with libgfxinit indeed
Yes, I never needed it with libgfxinit
To view, visit change 40813. To unsubscribe, or for help writing mail filters, visit settings.