Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46090 )
Change subject: mb/google/dedede: refactor DPTF section for simpler overrides
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede...
PS2, Line 102: .pl2 = {
: .min_power = 6000,
: .max_power = 20000,
: .time_window_min = 1 * MSECS_PER_SEC,
: .time_window_max = 1 * MSECS_PER_SEC,
: .granularity = 1000,
: }
If you wanted, you could separate out pl1 and pl2 in the override tree like so: […]
Thanks Tim for this info. For the same reason, I have specified both pl1 and pl2 above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e7cfe60c010ed4c07f9089325b289519e861f84
Gerrit-Change-Number: 46090
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 17:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment